-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute metadata attribute-type.h encapsulation #35731
Attribute metadata attribute-type.h encapsulation #35731
Conversation
Review changes with SemanticDiff. |
…s inside of .cpp file
b8f6448
to
c40b0b2
Compare
PR #35731: Size comparison from 8750c55 to c40b0b2 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more of a justification here: it seems this removes the need of attribute-type
from the header, which is fair but to what end? attribute-metadata is still not stand-alone because the cpp will need the header.
I am concerned if this paves the path to include more headers without adding dependencies.
…s inside of .cpp file (project-chip#35731)
Removed attribute-type.h from attribute-metadata and moved definitions inside of .cpp file to reduce the compilation dependencies of attribute-metadata.h